-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Customizable iCal Feeds for Dynamically Adding Events to Calendar Apps #487
Conversation
@bogdankharchenko I'm only seeing the one file in these commits, app/Http/Controllers/CalendarFeedController.php that looks related to #486. The rest are linting changes, as you mentioned. It seems there would be more files related to the UI, like Blade files, Javascript, and such. Was git add not run on the changes? If so, maybe we could make this PR more about the linting and push the calendar feed files into their own PR since the linting has added a good deal of noise here. |
Well, I revisited the the "Files Changed" and now I see a few more files. Somehow when I clicked it before, it was only showing like the first two commits. |
@allella I'm fine to merge this and at the very least give it a whirl in staging. |
#486
Note, laravel linter was ran, few style changes were made on other parts of the code base