Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customizable iCal Feeds for Dynamically Adding Events to Calendar Apps #487

Merged
merged 7 commits into from
Feb 4, 2025

Conversation

bogdankharchenko
Copy link
Collaborator

@bogdankharchenko bogdankharchenko commented Jan 31, 2025

#486

Note, laravel linter was ran, few style changes were made on other parts of the code base

@allella
Copy link
Member

allella commented Feb 3, 2025

@bogdankharchenko I'm only seeing the one file in these commits, app/Http/Controllers/CalendarFeedController.php that looks related to #486.

The rest are linting changes, as you mentioned.

It seems there would be more files related to the UI, like Blade files, Javascript, and such.

Was git add not run on the changes? If so, maybe we could make this PR more about the linting and push the calendar feed files into their own PR since the linting has added a good deal of noise here.

@allella
Copy link
Member

allella commented Feb 3, 2025

Well, I revisited the the "Files Changed" and now I see a few more files.

Somehow when I clicked it before, it was only showing like the first two commits.

@allella
Copy link
Member

allella commented Feb 3, 2025

Examples of the "description" field perhaps not being worth injecting into an iCal feed is tomorrow's CS2AI
image

and HG Nights, which has placeholder info and bullet points that make it pretty hard to read, and likely stale if the iCal doesn't keep the "description" field updated.
image

@bogdankharchenko
Copy link
Collaborator Author

@allella I'm fine to merge this and at the very least give it a whirl in staging.

@allella allella merged commit f07c026 into hackgvl:develop Feb 4, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants