Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queue up sync step #15

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/y-socket-io/client.js
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ export class SocketIOProvider extends Observable {

this.doc.on('update', this.onUpdateDoc)

this.socket.on('connect', () => this.onSocketConnection(resyncInterval))
this.socket.once('ready-for-sync', () => this.onSocketConnection(resyncInterval))

this.socket.on('disconnect', (event) => this.onSocketDisconnection(event))

Expand Down
56 changes: 46 additions & 10 deletions src/y-socket-io/y-socket-io.js
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,12 @@ export class YSocketIO {
*/
namespaceMap = new Map()

/**
* @type {Promise<void>[]}
* @private
*/
syncQueue = []

/**
* YSocketIO constructor.
* @constructor
Expand Down Expand Up @@ -157,16 +163,27 @@ export class YSocketIO {
this.initAwarenessListeners(socket)
this.initSocketListeners(socket)

const doc = await this.client.getDoc(namespace, 'index')

if (
api.isSmallerRedisId(doc.redisLastId, socket.user.initialRedisSubId)
) {
// our subscription is newer than the content that we received from the api
// need to renew subscription id and make sure that we catch the latest content.
this.subscriber.ensureSubId(stream, doc.redisLastId)
}
this.startSynchronization(socket, doc)
/**
* @type {Promise<void>}
*/
const task = new Promise((resolve) => {
assert(this.client)
this.client.getDoc(namespace, 'index').then((doc) => {
assert(socket.user)
assert(this.subscriber)
socket.emit('ready-for-sync')
if (
api.isSmallerRedisId(doc.redisLastId, socket.user.initialRedisSubId)
) {
// our subscription is newer than the content that we received from the api
// need to renew subscription id and make sure that we catch the latest content.
this.subscriber.ensureSubId(stream, doc.redisLastId)
}
this.startSynchronization(socket, doc)
resolve()
})
})
this.queueUpSyncTask(task)
})

return { client, subscriber }
Expand Down Expand Up @@ -336,6 +353,25 @@ export class YSocketIO {
}
}

/**
* @private
* @param {Promise<void>} task
*/
queueUpSyncTask (task) {
const len = this.syncQueue.push(task)
if (len === 1) this.consumeSyncQueue()
}

/**
* @private
*/
async consumeSyncQueue () {
if (this.syncQueue.length === 0) return
const task = this.syncQueue.shift()
await task
this.consumeSyncQueue()
}

/**
* @param {Namespace} namespace
*/
Expand Down
Loading