chore: changes in preparation for hlint 3.6 #1092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We will shortly bump our haskell.nix, which will bring in a new version of hlint. This adds some new linting checks which, before this commit, we would fail. Signed-off-by: Ben Price <[email protected]>
brprice
force-pushed
the
brprice/hlint-3.6-prep
branch
from
3c55265 to
a4d5d28
Compare
|
This should address the pre-commit-checks failures in #1084 |
brprice
commented
Jul 10, 2023
Comment on lines
274
to
+278
| genPrimCon' = do | ||
| genPrimCon <&> map (bimap (fmap $ PrimCon ()) (TCon ())) <&> filter (consistentTypes ty . snd) <&> \case | ||
| consistentCons <- | ||
| filter (consistentTypes ty . snd) . map (bimap (fmap $ PrimCon ()) (TCon ())) | ||
| <$> genPrimCon | ||
| pure $ case consistentCons of |
There was a problem hiding this comment.
There are some changes which I am less sure are improvements: 1/3
brprice
commented
Jul 10, 2023
Comment on lines
391
to
396
| ( typeInUse tdName td tydefs defs | ||
| || any (elem paramName . freeVarsTy) (concatMap valConArgs $ astTypeDefConstructors td) | ||
| || elemOf | ||
| (to astTypeDefConstructors % folded % to valConArgs % folded % getting _freeVarsTy % _2) | ||
| paramName | ||
| td | ||
| ) |
There was a problem hiding this comment.
There are some changes which I am less sure are improvements: 2/3
brprice
commented
Jul 10, 2023
Comment on lines
910
to
916
| when | ||
| (any (elem paramName . freeVarsTy) $ concatMap valConArgs $ astTypeDefConstructors td) | ||
| ( elemOf | ||
| (to astTypeDefConstructors % folded % to valConArgs % folded % getting _freeVarsTy % _2) | ||
| paramName | ||
| td | ||
| ) | ||
| (throwError $ TypeParamInUse tdName paramName) |
There was a problem hiding this comment.
There are some changes which I am less sure are improvements: 3/3
|
I'm fine with these, but I'm also OK with disabling some of the new lints. |
dhess
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We will shortly bump our haskell.nix, which will bring in a new version of hlint. This adds some new linting checks which, before this commit, we would fail.