Adds new integration [Sese-Schneider/ha-cover-time-based] #2088
Conversation
hacs-bot
bot
changed the title
| @@ -806,6 +806,7 @@ | |||
| "Sennevds/media_player.template", | |||
| "sergeylysov/sst_cloud", | |||
| "sermayoral/ha-samsungtv-encrypted", | |||
| "Sese-Schneider/ha-cover-time-based", | |||
There was a problem hiding this comment.
The current release is not compatible.
There was a problem hiding this comment.
I tried to figure out what you exactly mean by "not compatible", but didn't understand the issue.
Please help me understand what I need to do to make it compatible @ludeeus
Things I've checked and done:
- The changed LOC is at the correct place
- hassfest workflow passes link
- HACS workflow passes link
- Integration works in production with 2024.01 screenshot
- I've rechecked the publishing documentation if I did everything here
- I've added a brand link
There was a problem hiding this comment.
Your current release (v1.0.0) contains invalid data in hacs.json https://github.com/Sese-Schneider/ha-cover-time-based/blob/v1.0.0/hacs.json#L5
And missing data in manifest.json https://github.com/Sese-Schneider/ha-cover-time-based/blob/v1.0.0/custom_components/cover_time_based/manifest.json
https://github.com/hacs/default/actions/runs/7316774209/job/19931700422
There was a problem hiding this comment.
@ludeeus thank you for your assistance!
The issue was that for an unknown reason the release v1.0.0 was still marked as the latest release in the GitHub API, while the GitHub UI was correctly updated with the release v2.0.0.
I don't know why that has happened, might have been an issue with GitHub, but I can't tell ...
Anyways, this lead me to believe everything was fine (the tests in my repo did pass after all and v2.0.0 was available) while in this repo the wrong version was fetched and the tests failed.
I've republished the release v2.0.0 and pushed a new one v2.0.1 for good measure, which is the latest release now.
Everything should work now 🤞🏼 HACS hassfest
I apologize for the inconvenience
There was a problem hiding this comment.
Ah, i see 👍
I'll take another look at this repo the upcoming Sunday in that case 👍
|
Sorry about re-requesting the review, I forgot this is not allowed here and I'm used to pressing the button from work ... |
|
Your repository is now added to HACS 🎉
|
Adds integration [Sese-Schneider/ha-cover-time-based] Co-authored-by: Joakim Sørensen <[email protected]>
Checklist
Links
Link to current release: https://github.com/Sese-Schneider/ha-cover-time-based/releases/tag/v2.0.0
Link to successful HACS action (without the
ignorekey): https://github.com/Sese-Schneider/ha-cover-time-based/actions/runs/6430678535Link to successful hassfest action (if integration): https://github.com/Sese-Schneider/ha-cover-time-based/actions/runs/6425890011