chain, node: catch critical errors and shut down

handshake-org · Oct 21, 2021 · 4cd7381 · 4cd7381
1 parent 6f409ea
commit 4cd7381
Show file tree

Hide file tree

Showing 3 changed files with 29 additions and 3 deletions.
diff --git a/lib/blockchain/chain.js b/lib/blockchain/chain.js
@@ -935,8 +935,10 @@ class Chain extends AsyncEmitter {
       const ns = await view.getNameState(this.db, nameHash);
 
       if (ns.isNull()) {
-        if (!covenant.isClaim() && !covenant.isOpen())
+        if (!covenant.isClaim() && !covenant.isOpen()) {
+          this.emit('CRITICAL ERROR', 'Unexpected null NameState.');
           throw new Error('Database inconsistency.');
+        }
 
         const name = covenant.get(2);
         ns.set(name, height);
@@ -1832,7 +1834,12 @@ class Chain extends AsyncEmitter {
     }
 
     // Save block and connect inputs.
-    await this.db.save(entry, block, view);
+    try {
+      await this.db.save(entry, block, view);
+    } catch (e) {
+      this.emit('CRITICAL ERROR', e.message);
+      throw e;
+    }
 
     // Expose the new state.
     this.tip = entry;
@@ -1891,7 +1898,12 @@ class Chain extends AsyncEmitter {
         entry.height, util.hex32(entry.version));
     }
 
-    await this.db.save(entry, block);
+    try {
+      await this.db.save(entry, block);
+    } catch (e) {
+      this.emit('CRITICAL ERROR', e.message);
+      throw e;
+    }
 
     this.logger.warning('Heads up: Competing chain at height %d:'
       + ' tip-height=%d competitor-height=%d'

diff --git a/lib/node/fullnode.js b/lib/node/fullnode.js
@@ -194,6 +194,11 @@ class FullNode extends Node {
   init() {
     // Bind to errors
     this.chain.on('error', err => this.error(err));
+    this.chain.on('CRITICAL ERROR', (msg) => {
+      this.logger.warning(`Critical error, shutting down: ${msg}`);
+      this.close();
+    });
+
     this.mempool.on('error', err => this.error(err));
     this.pool.on('error', err => this.error(err));
     this.miner.on('error', err => this.error(err));
@@ -326,6 +331,7 @@ class FullNode extends Node {
     await this.handleClose();
 
     this.logger.info('Node is closed.');
+    this.emit('closed');
   }
 
   /**

diff --git a/lib/node/spvnode.js b/lib/node/spvnode.js
@@ -129,6 +129,11 @@ class SPVNode extends Node {
   init() {
     // Bind to errors
     this.chain.on('error', err => this.error(err));
+    this.chain.on('CRITICAL ERROR', (msg) => {
+      this.logger.warning(`Critical error, shutting down: ${msg}`);
+      this.close();
+    });
+
     this.pool.on('error', err => this.error(err));
 
     if (this.http)
@@ -213,6 +218,9 @@ class SPVNode extends Node {
     await this.pool.close();
     await this.chain.close();
     await this.handleClose();
+
+    this.logger.info('Node is closed.');
+    this.emit('closed');
   }
 
   /**