fixed bug in v.match which was causing it to always return true #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The extra pipe character at the end of the regular expression checking for technology-related words was causing the result of the match to be an array with one empty string when none of the other words was present:
[""]
Therefore, the match was always returning true, and butt was always being converted into butt.
This pull request will fix that bug and cause the expected behavior, but keep in mind that this will cause a lot of false negatives where short nodes are inside larger nodes, like this:
would render as "Our cloud is not the problem; our local storage is the problem."
but if the tag were removed, then "cloud" would render as "butt" (which is probably what you want), because of the presence of the word "storage" in the
tag.
So it's up to you whether to accept this pull request.