Merge pull request #71 from hannes/date_vs_string

Date vs string

duckdb-rfuns-r/tests/testthat/_snaps/spaceship.md

@@ -0,0 +1,58 @@
+# spaceship(<date> <=> <string>)
+
+    Code
+      spaceship_rfuns(as.Date("2024-03-21"), "not a date", "==")
+    Condition
+      Error in `map()`:
+      i In index: 1.
+      i With name: x.
+      Caused by error:
+      ! Error evaluating duckdb query: Conversion Error: date field value out of range: "not a date", expected format is (YYYY-MM-DD)
+
+---
+
+    Code
+      spaceship_r(as.Date("2024-03-21"), "not a date", "==")
+    Condition
+      Error in `map()`:
+      i In index: 1.
+      i With name: ==.
+      Caused by error in `charToDate()`:
+      ! character string is not in a standard unambiguous format
+
+# spaceship(<time> <=> <string>)
+
+    Code
+      spaceship_rfuns(time, time_chr_gibberish, "==")
+    Condition
+      Error in `map()`:
+      i In index: 1.
+      i With name: x.
+      Caused by error:
+      ! Error evaluating duckdb query: Conversion Error: timestamp field value "2024-02-21 14:00:00 gibberish" has a timestamp that is not UTC.
+      Use the TIMESTAMPTZ type with the ICU extension loaded to handle non-UTC timestamps.
+
+---
+
+    Code
+      spaceship_rfuns(as.POSIXct(strptime("2024-02-21 14:00:00", format = "%Y-%m-%d %H:%M:%S")),
+      "not a time", "==")
+    Condition
+      Error in `map()`:
+      i In index: 1.
+      i With name: x.
+      Caused by error:
+      ! Error evaluating duckdb query: Conversion Error: timestamp field value out of range: "not a time", expected format is (YYYY-MM-DD HH:MM:SS[.US][±HH:MM| ZONE])
+
+---
+
+    Code
+      spaceship_r(as.POSIXct(strptime("2024-02-21 14:00:00", format = "%Y-%m-%d %H:%M:%S")),
+      "not a time", "==")
+    Condition
+      Error in `map()`:
+      i In index: 1.
+      i With name: ==.
+      Caused by error in `as.POSIXlt.character()`:
+      ! character string is not in a standard unambiguous format
+

duckdb-rfuns-r/tests/testthat/gen/relop.txt

@@ -1,3 +1,21 @@
+"<time> <=> <string>"
+time <=> "2024-02-21 14:00:00"
+time <=> "2024-02-21 13:00:00"
+time <=> "2024-02-21 15:00:00"
+"2024-02-21 14:00:00" <=> time
+"2024-02-21 13:00:00" <=> time
+"2024-02-21 15:00:00" <=> time
+
+"<date> <=> <string>"
+date <=> "2024-02-21"
+date <=> "2024-02-22"
+date <=> "2024-02-20"
+date <=> "2024-03-21 and then some"
+"2024-02-21" <=> date
+"2024-02-22" <=> date
+"2024-02-20" <=> date
+"2024-03-21 and then some" <=> date
+
 "<date> <=> <date>"
 date <=> date
 date <=> date + 1

duckdb-rfuns-r/tests/testthat/helper-expect_spaceship.R

@@ -1,7 +1,26 @@
 expect_spaceship <- function(x, y) {
-  expect_equal(
+
+  ok_rfuns <- ok_r <- TRUE
+
+  rfuns <- tryCatch(
     spaceship_rfuns(x, y, keep.data = FALSE),
-    spaceship_r(x, y, keep.data = FALSE)
+    error = function(err) {
+      ok_rfuns <<- FALSE
+    }
+  )
+
+  r <- tryCatch(
+    spaceship_r(x, y, keep.data = FALSE),
+    error = function(err) {
+      ok_r <<- FALSE
+    }
   )
+
+  expect_equal(ok_r, ok_rfuns, info = "<=> should either pass for both or fail for both")
+
+  if (ok_r && ok_rfuns) {
+    expect_equal(rfuns, r)
+  }
+
 }
 

duckdb-rfuns-r/tests/testthat/helper-gen.R

@@ -1,6 +1,7 @@
 if (Sys.getenv("CI") == "" ) {
 
   Sys.setlocale("LC_COLLATE", "C")
+  Sys.setenv("TZ" = "UTC")
 
   # TODO: this should live in the package somewhere
   udfs <- c(
@@ -19,7 +20,7 @@ if (Sys.getenv("CI") == "" ) {
 
     args <- as.list(expr[-1])
     env <- new.env()
-    env$time <- as.POSIXct(strptime('2024-02-21 14:00:00', format = '%Y-%m-%d %H:%M:%S', tz = 'UTC'))
+    env$time <- as.POSIXct(strptime('2024-02-21 14:00:00', format = '%Y-%m-%d %H:%M:%S'))
     env$date <- as.Date("2024-02-21")
     env$NA_time <- as.POSIXct(NA)
     env$NA_date <- as.Date(NA)