(feature) Added types with docs for the all package #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @ggallovalle thanks for the contribution— glad to see you are interested in moving our Typescript support forward! Given the plan described in hapipal/discuss#4 we were actually planning to place all types for this ecosystem in a single repository, sort of like a mini @types project that we control ourselves. So I am going to close this, but this is still a useful contribution! It will likely just live in a different repository. Look for a comment from me shortly in that other issue 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I added types for the package. Hope you can merge it and publish a new version 😄
I'll be adding types to other hapipal projects, which one do you think I should do next?
Also I'm thinking of bringing forward the hapipal ecosystem to work with Typescript