Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a published version of skrifa #4

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Use a published version of skrifa #4

merged 1 commit into from
Jul 25, 2024

Conversation

rsheeter
Copy link
Collaborator

@rsheeter rsheeter commented Jul 25, 2024

Step toward #3

Migration to read-fonts instead of skrifa left for a follow-on

Some of the gid handling is dodgy wrt 16 vs 32 bit. Fully migration to read-fonts should tidy that up.

Copy link
Collaborator

@dfrg dfrg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was going to do this but you saved me the work :)

@rsheeter rsheeter merged commit 940cc74 into main Jul 25, 2024
4 checks passed
@rsheeter rsheeter deleted the cargo_skrifa branch July 25, 2024 23:47
@LaurenzV
Copy link
Contributor

LaurenzV commented Jul 26, 2024

TODO: read-fonts instead

Just FYI, for 100% correctness, I'm not sure whether it will be possible to replace skrifa completely. There is the one method glyph_extents, which (among other things) relies on outlining COLR glyphs to calculate the exact extents and are used in glyph_v_origin, position_mark and position_around_base. I guess it's an edge case since the outlining is only necessary for COLR, but still.

@behdad
Copy link
Member

behdad commented Jul 26, 2024

TODO: read-fonts instead

Just FYI, for 100% correctness, I'm not sure whether it will be possible to replace skrifa completely. There is the one method glyph_extents, which (among other things) relies on outlining COLR glyphs to calculate the exact extents and are used in glyph_v_origin, position_mark and position_around_base. I guess it's an edge case since the outlining is only necessary for COLR, but still.

I think in a forward-looking library, we can ignore cases where glyph_extents is not readily available (like CFF and COLRv1). We didn't have CFF extents for years in HB and no body complained. Also, because Windows doesn't have such a fallback mark positioning heuristic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants