bench: switch to criterion #149
Open
+79
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcdickinson
force-pushed
the
criterion
branch
from
60d4782
to
b16af5b
Compare
Switches the benchmark framework to Criterion. The default Rust std test framework has a hardcoded goal execution time of 1ms for each benchmark. This makes it unsuitable for sample-based profiling because the benchmark doesn't run for very long. Adds a utility script to run tests under a profiler.
jcdickinson
force-pushed
the
criterion
branch
from
b16af5b
to
34da136
Compare
|
I'm aware of |
@RazrFalcon what about the profiling issue I mentioned in the description? 1ms of sampling is certainly completely inadequate to create a high quality profile: https://github.com/rust-lang/rust/blob/master/library/test/src/bench.rs#L132 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a "PR that could have been an issue," I'm opening this PR to determine if this is a direction that the project wants to take.
Switches the benchmark framework to Criterion. The default Rust std test framework has a hardcoded goal execution time of 1ms for each benchmark. This makes it unsuitable for sample-based profiling because the benchmark doesn't run for very long.
Adds a utility script to run tests under a profiler.