String spaces #48
Merged
String spaces #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified ast.h to add a new token type for string, char type for quotes, and a parse state for string. Modified get_char_type and get_token to support spaces in strings ```slog (edge "well string") (edge "well another string)") (edge "yet another ! ? string") ``` Goes through succesfully
|
can you add a CI case for this? |
```slog ; Strings with spaces (strs 1 "well string") (strs 2 "well another string)") (strs 3 "yet another ! ? string") [(strs _ str_val) --> (just_str str_val)] ``` Goes Through.
|
@StarGazerM |
|
can you add the testcase in https://github.com/harp-lab/slog-lang1/tree/master/slog/tests/testcase , there is some CI script could read in test case there |
|
This commit has that added and the script is able to pick it up |
|
This commit only supports strings when loaded from the slog file and fails when loaded from csv files, as does the main branch. |
|
#49 Issue is also also worked in this PR, along with support for spaces in strings |
modified compiler/src/interpreter.rkt, strings in the source file were being hashed with quotes, but were being written to strings.csv without the quotes. modified client.py to remove the extra quotes being added, and causing hash mismatch for strings loaded from csv. added a test in stringtest in CI
|
@StarGazerM Strings from fact files work, CI test goes through. Please let me know if there is any concern. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified ast.h to add a new token type for string, char type for quotes,
and a parse state for string.
Modified get_char_type and get_token to support spaces in strings
Goes through successfully
Updated repl_and_runslog.md.