Add stargate strategy #74
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blackbarbie8
approved these changes
Jul 28, 2022
| @@ -0,0 +1,10 @@ | |||
| pragma solidity 0.5.16; | |||
|
|
|||
| interface ICurvePoolV2 { | |||
There was a problem hiding this comment.
contracts/base/interface/curve/ICurvePoolV2.sol
Blackbarbie8
approved these changes
Aug 15, 2022
CryptJS13
reviewed
Aug 15, 2022
| return getUint256(_STARGATE_REWARD_PID_SLOT); | ||
| } | ||
|
|
||
| function getRewardPoolValues() public returns (uint256[] memory values) { |
There was a problem hiding this comment.
What is the use of this function?
There was a problem hiding this comment.
So this function is to get current pending STG amounts from the pool, it's mostly unused, just to see how much we can harvest, it can be view function I guess.
Do you wanna keep it or remove it?
There was a problem hiding this comment.
I think it can be removed. We won't use it. We estimate profit of doHardWork by simulating the doHardWork transaction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add stargate strategy