IdleFinance Tranche Strategy #75
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CryptJS13
reviewed
Sep 9, 2022
| _profitSharingNumerator: 300, | ||
| _profitSharingDenominator: 1000, | ||
| _sell: true, | ||
| _sellFloor: 1e18, |
There was a problem hiding this comment.
This sellFloor is too high with WETH as rewardToken. It will now only liquidate if the total rewards are more than 1ETH. sellFloor could actually be set to 0, as we simulate profitability before running hardWork anyways.
| IERC20(underlying()).safeTransfer(vault(), underlyingBalance); | ||
| } | ||
|
|
||
| function withdrawToVault(uint256 amount) external restricted { |
There was a problem hiding this comment.
Is there no way to do a partial withdrawal? We do not want to withdraw all to vault if it is not necessary. The funds will sit idle in the vault until the next hardwork
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New strategy for
Idle Finance Tranche.There are two types of tranches,
Senior(AA)Tranche andJunior(BB)Tranche. Currently we only support theSeniorTranche since theJuniorTranche doesn't have any extra reward tokens.The token flow of the invest process is:
underlyingtoken to theIdleCDOcontract which will mint theAAtoken.AAtoken to the gauge to get theIDLEand the extra staking reward.The deposit token of
Lido - stETHtranche isstETHand the underlying token of the strategy iswstETHsince thestETHis rebalancing token. So therewrap/unwrapprocess oninvest/withdraw.Test outputs at blockNumber = 15356073: