change multipath default behaviour (backport #938) #978
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Currently when externalDisk support is not enabled, the installer adds a default kernel argument
multipath=off
viathird_party_kernel_arguments
.This works fine, however it breaks CSI's needing multipath since it cannot be enabled due to the kernel argument.
Disabling
multipath=off
fromthird_party_kernel_args
breaks the boot, when OS has been installed to nvme, as multipath attempts to create multiple paths for nvme disks.Solution:
To fix this a minor change has been made to default kernel argument being passed when multipath is not needed. This allows dracut to still boot with nvme disks as it ignores multipath module packaged in dracut, while allowing multipathd to be enable subsequently
In addition a default multipath config is added to ignore longhorn based volumes from multipath
Related Issue:
harvester/harvester#7438
Test plan:
Failure case:
This will fail as can be checked via
journalctl -fu multipathd
multipath=off
kernel argument by removing it from /oem/grubenvgrub2-editenv /oem/grubenv set third_party_kernel_args=""
Expect node boot to fail
Success case:
multipath -ll
This will be successful
This is an automatic backport of pull request #938 done by [Mergify](https://mergify.com).