single-node: Support single node setups #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for single-node setups. Signed-off-by: Moritz Röhrich <[email protected]>
albinsun
reviewed
Nov 11, 2024
There was a problem hiding this comment.
This PR changes the current design of usage and needs to be discuss further.
Current design is to have complete nodes plain spec (for preparing PXE yaml ...) and user just change harvester_cluster_nodes to meet the needs, includes adding nodes dynamically based on the test steps.
| path: /var/www/harvester/ | ||
| owner: www-data | ||
| recurse: yes | ||
| - name: copy config-join.yaml |
There was a problem hiding this comment.
Suppose initially I only setup one node and want to join other nodes now.
Does pxe VM will has the yaml for other nodes?
|
@m-ildefons |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for single-node setups.