Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #84 and #125 #152

Merged
merged 2 commits into from
Sep 12, 2011
Merged

Fixes #84 and #125 #152

merged 2 commits into from
Sep 12, 2011

Conversation

h3adache
Copy link
Contributor

@h3adache h3adache commented Aug 4, 2011

Removed data parameter.
Use option parameter for "no results found text"

Note:

  • This patch is only for the jquery version
  • I don't really like how I did the no results found text since it's not really obvious what needs to be set.
    I know this can just be something for documentation but would be nice if someone comes up with a more 'friendly' way.

@aziz
Copy link
Contributor

aziz commented Aug 4, 2011

I like it. It would be even better if jQuery and Prototype share similar API. there should be an identical way of initializing chosen select.

@pfiller pfiller merged commit f9674e7 into harvesthq:master Sep 12, 2011
@pfiller
Copy link
Contributor

pfiller commented Sep 12, 2011

Thanks, @h3adache -- I've merged and included a similar array for the prototype version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants