Script improvements #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Usage and ownership of null.com is unclear. example.org is defined as example domain. Ref RFC 6761.
Shutdown containers are not shown in `docker ps` but are still laying around. Running with `--rm` cleans them up when they terminate.
It is already included in the `ENV` Dockerfile instruction.
|
This is solid. Thanks so much! |
|
You are welcome, thanks for merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks again for the great work! I hope I can contribute some more in the future.
If you don’t like some changes, the commits are small enough that they can be reverted or you could cherry-pick some of them. I found it easier than opening a couple of PR. Just tell me how you prefer it.