fix: workaround for eth_getCode when token was not yet created
#92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luis Mastrangelo <[email protected]>
Signed-off-by: Luis Mastrangelo <[email protected]>
Signed-off-by: Luis Mastrangelo <[email protected]>
Signed-off-by: Luis Mastrangelo <[email protected]>
Signed-off-by: Luis Mastrangelo <[email protected]>
Signed-off-by: Luis Mastrangelo <[email protected]>
Signed-off-by: Luis Mastrangelo <[email protected]>
Signed-off-by: Luis Mastrangelo <[email protected]>
Signed-off-by: Luis Mastrangelo <[email protected]>
Signed-off-by: Luis Mastrangelo <[email protected]>
Signed-off-by: Luis Mastrangelo <[email protected]>
Signed-off-by: Luis Mastrangelo <[email protected]>
Signed-off-by: Luis Mastrangelo <[email protected]>
arianejasuwienas
approved these changes
Oct 31, 2024
Nana-EC
approved these changes
Oct 31, 2024
acuarica
added a commit
that referenced
this pull request
Nov 1, 2024
Signed-off-by: Luis Mastrangelo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR provides a workaround for issue hashgraph/hedera-json-rpc-relay#3155 in the JSON-RPC Relay. These changes were implemented in the
json-rpc-forwarder.js. Given the logic to get the redirect bytecode (HIP-719) was starting to get used in several places, we refactored it into thegetHIP719Codefunction.Note that some Foundry tests had to be updated after moving HIP719 bytecode (f8fbf97).
Additionally, some other changes were introduced to avoid introducing technical debt.
ethereum-cryptographypackage to avoid hoisting it 16b79b8ethersfrom root because is not needed there 4109b0flockfiles in workspace packages 3108478nullinIMirrorNodeClient(nullrepresents error while performing the request) 78cd629loggertype and remove unusedpinodependency a74f864Related issue(s):
Fixes #91.
Notes for reviewer:
Checklist