HIP-820 signMessages discussion #840
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an original suggestion to more closely align the `signMessages` function with the signature provider API Signed-off-by: Tyler <[email protected]>
✅ Deploy Preview for hedera-hips ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
bugbytesinc
suggested changes
Dec 5, 2023
There was a problem hiding this comment.
This should not be changed. hedera_signedMessage is modeled after the ETH equivalent in wallet connect. Furthermore the SignatureMap contains important metadata regarding the keys which sign the message. This change would break supporting multi-signature scenarios.
Signed-off-by: Tyler <[email protected]>
Signed-off-by: Tyler <[email protected]>
|
I would also vote for keeping SignatureMap |
|
closing per group discussion |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an original suggestion to more closely align the
signMessagesfunction with the signature provider APIDescription:
This PR is for discussion. In practice, the signer functionality supports multiple messages. This PR is to see if the WalletConnect function should more closely align with that functionality:
https://docs.hedera.com/hedera/sdks-and-apis/sdks/signature-provider/signer