Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update datadog.mdx #22077

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update datadog.mdx #22077

wants to merge 2 commits into from

Conversation

natemollica-nm
Copy link
Contributor

Description

Reword the end user note to be in an English-understandable format.

Original

Currently, the annotations configured by the Helm overrides with Consul RPC TLS enabled assume server and ca certificate secrets are shared with the Datadog agent release namespace and mount the valid tls.crt, tls.key, and ca.crt secret volumes at the /etc/datadog-agent/conf.d/consul.d/certs path on the Datadog Agent, agent container.

Update

Currently, the annotations configured by the Helm overrides, when Consul RPC TLS is enabled, presume the user has shared the server and ca certificate secrets with the Datadog agent's Kubernetes namespace and mount the valid tls.crt, tls.key, and ca.crt secret volumes at the /etc/datadog-agent/conf.d/consul.d/certs path within the Datadog Agent pod's agent container.

Testing & Reproduction steps

  • N/A

Links

  • N/A

PR Checklist

  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

Reword the end user note to be in an English-understandable format.
@natemollica-nm natemollica-nm added the type/docs Documentation needs to be created/updated/clarified label Jan 16, 2025
@natemollica-nm natemollica-nm requested a review from a team as a code owner January 16, 2025 00:11
@boruszak boruszak added pr/no-changelog PR does not need a corresponding .changelog entry backport/1.20 Changes are backported to 1.20 labels Jan 16, 2025
Copy link
Contributor

@boruszak boruszak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for addressing this confusing note!

I left some additional suggestions to help clarify these sentences and align with our style guide! Please implement the suggestions and then I will approve you to merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.20 Changes are backported to 1.20 pr/no-changelog PR does not need a corresponding .changelog entry type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants