Skip to content

Commit

Permalink
fix(components): ember-composable-helpers -> `@nullvoxpopuli/ember-…
Browse files Browse the repository at this point in the history
…composable-helpers` (#2493)
  • Loading branch information
aklkv authored Feb 26, 2025
1 parent 96ea0f0 commit 236f24c
Show file tree
Hide file tree
Showing 7 changed files with 31 additions and 43 deletions.
5 changes: 5 additions & 0 deletions .changeset/polite-shirts-fix.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@hashicorp/design-system-components": patch
---

Swap unmaintained `ember-composable-helpers` with `@nullvoxpopuli/ember-composable-helpers`
3 changes: 3 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@
"pnpm": ">= 10.0.0"
},
"pnpm": {
"overrides": {
"ember-composable-helpers": "npm:@nullvoxpopuli/ember-composable-helpers@^5.2.9"
},
"patchedDependencies": {
"@embroider/core": "patches/@embroider__core.patch",
"@glint/environment-ember-loose": "patches/@glint__environment-ember-loose.patch",
Expand Down
4 changes: 2 additions & 2 deletions packages/components/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -50,12 +50,12 @@
"@hashicorp/design-system-tokens": "^2.3.0",
"@hashicorp/flight-icons": "^3.9.0",
"@lezer/highlight": "^1.2.1",
"@nullvoxpopuli/ember-composable-helpers": "^5.2.9",
"clipboard-polyfill": "^4.1.1",
"codemirror-lang-hcl": "^0.0.0-beta.2",
"decorator-transforms": "^2.3.0",
"ember-a11y-refocus": "^4.1.4",
"ember-cli-sass": "^11.0.1",
"ember-composable-helpers": "^5.0.0",
"ember-concurrency": "^4.0.2",
"ember-element-helper": "^0.8.6",
"ember-focus-trap": "^1.1.1",
Expand Down Expand Up @@ -364,4 +364,4 @@
"engines": {
"node": ">= 18"
}
}
}
55 changes: 17 additions & 38 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions website/cspell-config/project-words.txt
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ wireframe
Wireframes
wireframing
workramp
nullvoxpopuli

# Component-specific
dont
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ Similar to the basic Advanced Table, you can insert your own content into the `:

!!! Info

This component takes advantage of the `sort-by` helper provided by [ember-composable-helpers](https://github.com/DockYard/ember-composable-helpers).
This component takes advantage of the `sort-by` helper provided by [@nullvoxpopuli/ember-composable-helpers](https://github.com/NullVoxPopuli/ember-composable-helpers)

!!!

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ For clarity, there are a couple of important points to note here:

!!! Info

This component takes advantage of the `sort-by` helper provided by [ember-composable-helpers](https://github.com/DockYard/ember-composable-helpers).
This component takes advantage of the `sort-by` helper provided by [@nullvoxpopuli/ember-composable-helpers](https://github.com/NullVoxPopuli/ember-composable-helpers).

!!!

Expand Down Expand Up @@ -311,7 +311,7 @@ In the `<:head>` the `setSortBy` function is invoked when the `<ThSort>` element

In the `<:body>` the values of `sortBy` and `sortOrder` are provided instead as arguments to a consumer-side function that takes care of custom sorting the model/data.

_Notice: in this case for the example we're using the [`call` helper](https://github.com/DockYard/ember-composable-helpers#call) from [ember-composable-helpers](https://github.com/DockYard/ember-composable-helpers)._
_Notice: in this case for the example we're using the [`call` helper](https://github.com/NullVoxPopuli/ember-composable-helpers?tab=readme-ov-file#call) from [@nullvoxpopuli/ember-composable-helpers](https://github.com/NullVoxPopuli/ember-composable-helpers)._

The sorting function in the backing class code will look something like this (the actual implementation will depend on the consumer-side/business-logic context):

Expand Down

0 comments on commit 236f24c

Please sign in to comment.