-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🧪 [SPIKE] Component-level tokens exploration #2471
Draft
didoo
wants to merge
6
commits into
main
Choose a base branch
from
spike-component-level-tokens-experiment
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
didoo
force-pushed
the
spike-component-level-tokens-experiment
branch
from
October 1, 2024 21:38
f776c4d
to
db0346d
Compare
didoo
force-pushed
the
spike-component-level-tokens-experiment
branch
from
November 7, 2024 15:30
db0346d
to
e0accd2
Compare
didoo
force-pushed
the
spike-component-level-tokens-experiment
branch
from
November 12, 2024 18:19
32a003b
to
c4729fe
Compare
added missing dependency `nodemon`
(mainly coming from `Badge` apart from horizontal padding)
Not 100% exactly as it was before, visually, because of how the custom border/focus implementation for the different variants
didoo
force-pushed
the
spike-component-level-tokens-experiment
branch
from
November 12, 2024 18:20
c4729fe
to
6458d28
Compare
didoo
force-pushed
the
spike-component-level-tokens-experiment
branch
from
November 12, 2024 19:04
6458d28
to
c32ba59
Compare
WIP SQ
didoo
force-pushed
the
spike-component-level-tokens-experiment
branch
from
November 12, 2024 19:13
c32ba59
to
3f5308f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚨 DO NOT MERGE 🚨
📌 Summary
Branch used for exploring what is the impact of introducing full coverage for component-level tokens, in relation to theming (for dark/light mode, as well as to "emulate" other design languages).
👀 Comparisons
🔗 External links
Jira tickets: