Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transfer maintainers to consul, boundary, and nomad #45

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

claire-labry
Copy link
Contributor

This PR transfers maintainership to the Consul, Nomad, and Boundary teams as the Release Engineering team are not the correct maintainers for this repository.

@claire-labry claire-labry requested review from a team, alvin-huang and dlaguerta and removed request for a team June 30, 2023 18:43
@analogue
Copy link

👍 from consul-core team.

@jefferai
Copy link
Member

jefferai commented Sep 6, 2023

I don't believe this is the right set. Probably it should be @mkeeler and myself?

@analogue
Copy link

analogue commented Sep 6, 2023

I don't believe this is the right set. Probably it should be @mkeeler and myself?

For sustainability, IMO teams/groups/aliases should be owners, not individuals. Teams should have the context to redirect to individuals when necessary.

@mkeeler
Copy link
Member

mkeeler commented Sep 6, 2023

On the one hand @jefferai and myself have the most background in this repo outside of Mitchell. But whether we want to have individuals as code owners I am less certain. So far with other libraries shared amongst multiple products we seem to have been successful with developers new to a projects finding the right people to double check their assumptions for their first PRs.

I think the benefits of team ownership probably outweigh the risks of letting something through that we shouldn't.

@jefferai
Copy link
Member

jefferai commented Sep 6, 2023

So far with other libraries shared amongst multiple products we seem to have been successful with developers new to a projects finding the right people to double check their assumptions for their first PRs.

This does not match with my experience at all, which is why I suggested me and Matt.

I would suggest that the two of us should be codeowners but the comments in the file should mention that it is used by the various projects.

Copy link

@dekimsey dekimsey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants