Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

document lxc task config option #13349

Closed
wants to merge 1 commit into from
Closed

document lxc task config option #13349

wants to merge 1 commit into from

Conversation

h0tw1r3
Copy link
Contributor

@h0tw1r3 h0tw1r3 commented Jun 13, 2022

DerekStrickland
DerekStrickland suggested changes Jun 13, 2022
View reviewed changes
Copy link
Contributor

@DerekStrickland DerekStrickland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this! I have a quick request to make the md links consistent. Please see inline. You can just accept the suggestions and it will apply a patch.

@DerekStrickland DerekStrickland self-assigned this Jun 13, 2022
@DerekStrickland DerekStrickland added theme/docs Documentation issues and enhancements theme/driver/lxc labels Jun 13, 2022
@h0tw1r3 h0tw1r3 force-pushed the lxc-config-option branch from cc9db06 to c144b9d Compare June 13, 2022 16:52
@DerekStrickland DerekStrickland requested a review from lgfa29 June 13, 2022 19:33
DerekStrickland
DerekStrickland approved these changes Jun 13, 2022
View reviewed changes
Copy link
Contributor

@DerekStrickland DerekStrickland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Tagging @lgfa29 for a second set of eyes.

tgross
tgross reviewed Jul 5, 2022
View reviewed changes
Copy link
Member

@tgross tgross left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note this blocked on merging hashicorp/nomad-driver-lxc#38, which might not be mergeable.

@tgross tgross added the stage/waiting-on-upstream This issue is waiting on an upstream PR review label Jul 5, 2022
@tgross tgross added the stage/needs-rebase This PR needs to be rebased on main before it can be backported to pick up new BPA workflows label May 17, 2024
@aimeeu
Copy link
Contributor

aimeeu commented Oct 10, 2024

Nomad 1.9 removes the deprecated LXC driver so I'm closing this PR.

@aimeeu aimeeu closed this Oct 10, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 8, 2025

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tgross tgross tgross left review comments

@DerekStrickland DerekStrickland DerekStrickland approved these changes

@lgfa29 lgfa29 Awaiting requested review from lgfa29

Assignees

@DerekStrickland DerekStrickland

Labels
stage/needs-rebase This PR needs to be rebased on main before it can be backported to pick up new BPA workflows stage/waiting-on-upstream This issue is waiting on an upstream PR review theme/docs Documentation issues and enhancements theme/driver/lxc
Projects
Nomad - Community Issues Triage
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@h0tw1r3 @aimeeu @DerekStrickland @tgross