Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data source support for response body arrays #78

Merged
merged 7 commits into from
Oct 24, 2023

Conversation

austinvalle
Copy link
Member

Closes #16

This PR introduces logic to detect a response body array for a data source, then map to a single collection attribute. This is then merged with query/path parameters as usual.

@austinvalle austinvalle added this to the v0.2.0 milestone Oct 19, 2023
@austinvalle austinvalle requested a review from a team as a code owner October 19, 2023 16:07
Copy link
Contributor

@bendbennett bendbennett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🚀

@austinvalle
Copy link
Member Author

@bflad or @bendbennett,

I updated the PR to default to set in 53d4c77, let me know if that looks good 👍🏻

Copy link
Contributor

@bendbennett bendbennett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@austinvalle austinvalle merged commit e61922c into main Oct 24, 2023
@austinvalle austinvalle deleted the av/array-datasources branch October 24, 2023 13:41
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider how best to handle array response mapping (like data source query endpoints)
3 participants