golangci enable additional linters (prealloc predeclared whitespace tagalign) and fix issues #27959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
service/storage
service/mssql
katbyte
changed the title
katbyte
changed the title
katbyte
changed the title
katbyte
changed the title
mbfrahry
requested changes
Nov 11, 2024
| var output []ClusterSettingModel | ||
| if input == nil || len(*input) == 0 { | ||
| return output | ||
| if len(*input) == 0 { |
There was a problem hiding this comment.
I believe we still want to check if input is nil before casing to it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enabled linters prealloc predeclared whitespace tagalign
white space linter does not seem to have the same impact anymore (6m vs 5m)
updated golangci.yml to 1.22
This is a (please select all that apply):
Related Issue(s)
Fixes #0000
Note
If this PR changes meaningfully during the course of review please update the title and description as required.