FourPointOh - remove from services A-I with low find counts #28021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
service/app-service
service/cosmosdb
service/iot-hub
service/cdn
service/automation
service/databricks
service/data-factory
service/batch
service/analysis
service/attestation
service/databox-edge
service/connections
service/container-apps
size/XL
labels
stephybun
reviewed
Nov 15, 2024
internal/services/databricks/databricks_customer_managed_key_resource.go
Outdated
Show resolved
Hide resolved
internal/services/datafactory/data_factory_integration_runtime_azure_resource.go
Outdated
Show resolved
Hide resolved
…_azure_resource.go Co-authored-by: stephybun <[email protected]>
mbfrahry
requested changes
Nov 15, 2024
| "azurerm_databricks_workspace_root_dbfs_customer_managed_key": resourceDatabricksWorkspaceRootDbfsCustomerManagedKey(), | ||
| "azurerm_databricks_virtual_network_peering": resourceDatabricksVirtualNetworkPeering(), | ||
| "azurerm_databricks_workspace_customer_managed_key": resourceDatabricksWorkspaceCustomerManagedKey(), // TODO: Remove in 5.0 |
There was a problem hiding this comment.
This should be in a !features.FivePointOhBeta() check so we don't get into the same situation of forgetting to remove it
Co-authored-by: Matthew Frahry <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a (please select all that apply):
Related Issue(s)
Fixes #0000
Note
If this PR changes meaningfully during the course of review please update the title and description as required.