azurerm_security_center_auto_provisioning - deprecate resource

[ziyeqf]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

The capability is deprecated per the document

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
  For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

• I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
• I have written new tests for my resource or datasource changes & updated any relevent documentation.
• I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
• (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

• My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

The resource is deprecated on the service side and the tests can not pass any more with following error:

        Error: updating auto-provisioning setting for Auto Provisioning Setting: (Name "default"): security.AutoProvisioningSettingsClient#Create: Failure responding to request: StatusCode=400 -- Original Error: autorest/azure: Service returned an error. Status=400 Code="Deprecated" Message="Log Analytics auto provisioning is deprecated and can no longer be enabled."

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

• azurerm_security_center_auto_provisioning - deprecate resource [azurerm_security_center_auto_provisioning - deprecate resource #28030]

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Related Issue(s)

Fixes #27670

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

[stephybun]

Thanks @ziyeqf, this looks good but the link in the description doesn't mention the deprecation, maybe I missed it. Could you please double check?

[stephybun]

This should be under the ### Removed Resource section and it would be good to provide a link to the deprecation message as well

Suggested change

	### `azurerm_security_center_auto_provisioning`
	* This deprecated resources has been removed from the Azure Provider.
	### `azurerm_security_center_auto_provisioning`
	* This deprecated resource has been removed from the Azure Provider.

[ziyeqf]

Somehow I pasted a wrong link... it's here

[stephybun]

Suggested change

	* This deprecated resource has been removed from the Azure Provider. [document](https://learn.microsoft.com/en-us/azure/defender-for-cloud/prepare-deprecation-log-analytics-mma-agent#log-analytics-agent-autoprovisioning-experience---deprecation-plan)
	* This deprecated resource has been removed from the Azure Provider. Please see the [documention for more details](https://learn.microsoft.com/en-us/azure/defender-for-cloud/prepare-deprecation-log-analytics-mma-agent#log-analytics-agent-autoprovisioning-experience---deprecation-plan).

[stephybun]

This is now linked inside a link?

[ziyeqf]

kind of carelessness, sry for that

[stephybun]

Thanks @ziyeqf LGTM 👍