Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_storage_container upgrade to mgmt plan 2019-06-01 #9031

Closed
wants to merge 13 commits into from

Conversation

yupwei68
Copy link
Contributor

Fix #3722

Dependent on resource encryption scope: #8894

As for permission issue, confirmed by the service team, only "Contributor" role is required for all management plan apis. I've tested with my oldest service principal with only "Contributor" role (assigned one year ago) and tests have passed.

All tests have passed:
=== RUN TestAccAzureRMStorageContainer_basic
=== PAUSE TestAccAzureRMStorageContainer_basic
=== CONT TestAccAzureRMStorageContainer_basic
--- PASS: TestAccAzureRMStorageContainer_basic (135.90s)
=== RUN TestAccAzureRMStorageContainer_deleteAndRecreate
=== PAUSE TestAccAzureRMStorageContainer_deleteAndRecreate
=== CONT TestAccAzureRMStorageContainer_deleteAndRecreate
--- PASS: TestAccAzureRMStorageContainer_deleteAndRecreate (252.52s)
=== RUN TestAccAzureRMStorageContainer_basicAzureADAuth
=== PAUSE TestAccAzureRMStorageContainer_basicAzureADAuth
=== CONT TestAccAzureRMStorageContainer_basicAzureADAuth
--- PASS: TestAccAzureRMStorageContainer_basicAzureADAuth (137.88s)
=== RUN TestAccAzureRMStorageContainer_requiresImport
=== PAUSE TestAccAzureRMStorageContainer_requiresImport
=== CONT TestAccAzureRMStorageContainer_requiresImport
--- PASS: TestAccAzureRMStorageContainer_requiresImport (143.34s)
=== RUN TestAccAzureRMStorageContainer_update
=== PAUSE TestAccAzureRMStorageContainer_update
=== CONT TestAccAzureRMStorageContainer_update
--- PASS: TestAccAzureRMStorageContainer_update (164.16s)
=== RUN TestAccAzureRMStorageContainer_metaData
=== PAUSE TestAccAzureRMStorageContainer_metaData
=== CONT TestAccAzureRMStorageContainer_metaData
--- PASS: TestAccAzureRMStorageContainer_metaData (207.31s)
=== RUN TestAccAzureRMStorageContainer_encryptionScope
=== PAUSE TestAccAzureRMStorageContainer_encryptionScope
=== CONT TestAccAzureRMStorageContainer_encryptionScope
--- PASS: TestAccAzureRMStorageContainer_encryptionScope (141.72s)
=== RUN TestAccAzureRMStorageContainer_immutabilityPolicy
=== PAUSE TestAccAzureRMStorageContainer_immutabilityPolicy
=== CONT TestAccAzureRMStorageContainer_immutabilityPolicy
--- PASS: TestAccAzureRMStorageContainer_immutabilityPolicy (245.27s)
=== RUN TestAccAzureRMStorageContainer_legalHold
=== PAUSE TestAccAzureRMStorageContainer_legalHold
=== CONT TestAccAzureRMStorageContainer_legalHold
--- PASS: TestAccAzureRMStorageContainer_legalHold (242.68s)
=== RUN TestAccAzureRMStorageContainer_disappears
=== PAUSE TestAccAzureRMStorageContainer_disappears
=== CONT TestAccAzureRMStorageContainer_disappears
--- PASS: TestAccAzureRMStorageContainer_disappears (130.68s)
=== RUN TestAccAzureRMStorageContainer_root
=== PAUSE TestAccAzureRMStorageContainer_root
=== CONT TestAccAzureRMStorageContainer_root
--- PASS: TestAccAzureRMStorageContainer_root (130.01s)
=== RUN TestAccAzureRMStorageContainer_web
=== PAUSE TestAccAzureRMStorageContainer_web
=== CONT TestAccAzureRMStorageContainer_web
--- PASS: TestAccAzureRMStorageContainer_web (132.45s)
=== RUN TestValidateArmStorageContainerName
--- PASS: TestValidateArmStorageContainerName (0.00s)

=== RUN TestAccDataSourceArmStorageContainer_basic
=== PAUSE TestAccDataSourceArmStorageContainer_basic
=== CONT TestAccDataSourceArmStorageContainer_basic
--- PASS: TestAccDataSourceArmStorageContainer_basic (139.11s)

@tombuildsstuff
Copy link
Contributor

hi @yupwei68

Thanks for this PR.

As discussed offline, unfortunately we're unable to switch to using the Resource Manager API exclusively here due to this being a breaking change. As I mentioned last week - we'll be taking a look into working out what migration path is possible here - but at this time unfortunately no PR's will be accepted which migrate from the Data Plane to the Resource Manager API's until the Resource Manager API's are usable for existing users without introducing a breaking permissions change.

Thanks!

@ghost
Copy link

ghost commented Nov 26, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 26, 2020
@yupwei68 yupwei68 deleted the wyp-storage-container2 branch June 7, 2021 06:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for setting access policies on storage containers
2 participants