Add name constraints params for PKI certificate resources. #2396
+495
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorr
force-pushed
the
victorr/vault-33180-add-pki-name-constraints-params
branch
from
b1bf290 to
845bcd4
Compare
victorr
force-pushed
the
victorr/vault-33180-add-pki-name-constraints-params
branch
from
845bcd4 to
fad951f
Compare
Add the new parameters used to create the name constaints extension: * excluded_dns_domains * permitted_ip_ranges * excluded_ip_ranges * permitted_email_addresses * excluded_email_addresses * permitted_uri_domains * excluded_uri_domains To resources: * vault_pki_secret_backend_root_cert * vault_pki_secret_backend_root_sign_intermediate
victorr
force-pushed
the
victorr/vault-33180-add-pki-name-constraints-params
branch
from
fad951f to
3aa6b7d
Compare
|
Branch hack-to-run-name-constraints-provider-tests can be used to run the tests against a dev build of Vault. |
stevendpclark
requested changes
Jan 28, 2025
stevendpclark
approved these changes
Jan 28, 2025
victorr
deleted the
victorr/vault-33180-add-pki-name-constraints-params
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the new parameters used to create the name constaints extension:
To resources:
The new fields were added in Vault 1.19. See hashicorp/vault#29245.
Checklist
Community Note