Remove registering authentication provider #1670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes `contributes.authentication` from the package.json manifest to restore workspace extension enablement. From the [discussion thread](microsoft/vscode-discussions#930) and our investigation we can conclude (if not verify completely as there is no documentation) that `contributes.authentication` is a way to advertise use of the provider to outside extensions and not necessary for internal functionality. This means we can remove advertising the auth provider without breaking existing functionality.
1 task
dbanck
approved these changes
Jan 23, 2024
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes
contributes.authenticationfrom the package.json manifest to restore workspace extension enablement.From the discussion thread and our investigation we can conclude (if not verify completely as there is no documentation) that
contributes.authenticationis a way to advertise use of the provider to outside extensions and not necessary for internal functionality. This means we can remove advertising the auth provider without breaking existing functionality.