Skip to content

Commit

Permalink
Switch to NodeJS LTS 20 "Iron"
Browse files Browse the repository at this point in the history
NodeJS 18 "Hydrogen" will be EOL in April 2025.

Closes issue opensearch-project#8463.

Note: The latest LTS (22 "Jod") fails to build.

Signed-off-by: hashworks <[email protected]>
  • Loading branch information
hashworks committed Jan 10, 2025
1 parent e401613 commit 1a602a8
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion .node-version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
18.19.0
20.18.1
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
18.19.0
20.18.1
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
ARG NODE_VERSION=18.19.0
ARG NODE_VERSION=20.18.1
FROM node:${NODE_VERSION} AS base

ENV HOME '.'
Expand Down
6 changes: 3 additions & 3 deletions TESTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ In general, we recommend four tiers of tests:

# Requirements
* Install the latest NodeJS, [NPM](https://www.npmjs.com/get-npm) and [Yarn](https://classic.yarnpkg.com/en/docs/install/#mac-stable)
* `nvm install v18.19.0`
* Install the specified NodeJS, [NPM](https://www.npmjs.com/get-npm) and [Yarn](https://classic.yarnpkg.com/en/docs/install/#mac-stable)
* `nvm install v20.18.1`
* `npm install -g yarn`

# Running tests
Expand Down Expand Up @@ -122,4 +122,4 @@ sudo apt-get install -y --allow-downgrades /tmp/chrome.deb
Although Jest is the standard for this project, there are a few Mocha tests that still exist. You can run these tests by running:
`yarn test:mocha`

However, these tests will eventually be migrated; please avoid writing new Mocha tests. For further questions or to check the status, please see this [issue](https://github.com/opensearch-project/OpenSearch-Dashboards/issues/215).
However, these tests will eventually be migrated; please avoid writing new Mocha tests. For further questions or to check the status, please see this [issue](https://github.com/opensearch-project/OpenSearch-Dashboards/issues/215).
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -503,7 +503,7 @@
"zlib": "^1.0.5"
},
"engines": {
"node": ">=14.20.1 <19",
"node": ">=14.20.1 <21",
"yarn": "^1.22.10"
}
}

0 comments on commit 1a602a8

Please sign in to comment.