Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gitdata create endpoints #397

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add gitdata create endpoints #397

wants to merge 3 commits into from

Conversation

rvlander
Copy link

Adds the following features:

  • Adds function to get commit using auth
  • Adds endpoint to create new tree
  • Adds endpoint to create new commit

phadej
phadej suggested changes Sep 13, 2019
View reviewed changes
Copy link
Contributor

@phadej phadej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't re-export new *R requests from GitHub module.

@rvlander
Copy link
Author

I am unsure of what you are asking.

@jhrcek
Copy link
Contributor

jhrcek commented Dec 9, 2019

@rvlander he probably means that you should export the new functions ending in R (createCommitR and createTreeR) which you added and reexport them from the Github module.

@andreasabel
Copy link
Member

@rvlander Is there still interest in this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phadej phadej phadej requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rvlander @jhrcek @andreasabel @phadej