-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework CI #223
Merged
Merged
Rework CI #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorki
force-pushed
the
srk/haskell-ci
branch
from
November 11, 2023 17:14
37d7291
to
610530c
Compare
This reverts commit 35da3c9.
This makes it not pick-up linux-namespaces dependency which is Linux specific.
sorki
force-pushed
the
srk/haskell-ci
branch
from
November 11, 2023 18:00
610530c
to
39bf386
Compare
let it fail in CI which is configured to build it at least once a month so we know about any possible breakage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework CI to use https://github.com/sorki/github-actions-dhall/ which was suggested couple years ago by @sjakobi
The original https://github.com/vmchale/github-actions-dhall is not actively maintained so I maintain a fork with updated
haskell-ci.dhall
since then and it is working quite well in numerous projects (another TODO for me to make it a proper fork with onlyhaskell-ci.dhall
and maybenix-haskell-ci.dhall
.. sorki/github-actions-dhall#3).This also switches back to building both libs together to not require splitting pull requests into
-core
and-remote
related ones and releasing-core
first (and then re-submitting the-remote
PR) if we need changes to both of them which puts additional burden to contributors and maintainers. The interaction of both can be handled by upper bounds easily or we release both at once iff needed.I've had to disable
io-testsuite
of remote for now #222 which I'll investigate later.cc @domenkozar