Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix static builds lacking git info #10693

Merged
merged 2 commits into from
Feb 27, 2025
Merged

Conversation

geekosaur
Copy link
Collaborator

Please read Github PR Conventions and then fill in one of these two templates.


Template B: This PR does not modify behaviour or interface

E.g. the PR only touches documentation or tests, does refactorings, etc.

Include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).

@geekosaur geekosaur force-pushed the static-git-info branch 2 times, most recently from a186c91 to a9c0a0c Compare December 31, 2024 14:57
Copy link
Collaborator

@ulysses4ever ulysses4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the interest of experimenting, this could be fast-tracked, I hope.

@ulysses4ever
Copy link
Collaborator

If it's "ready for review", maybe un-draft it too?

@ulysses4ever ulysses4ever requested a review from Mikolaj December 31, 2024 15:19
@geekosaur
Copy link
Collaborator Author

Haven't yet modified the git stuff to degrade gracefully on lack of git info yet; been focused on trying to make the Alpine job provide it.

@geekosaur geekosaur marked this pull request as ready for review December 31, 2024 15:39
@ulysses4ever
Copy link
Collaborator

All right, it's up to you, of course. In my mind, these were separate issues. But I guess it may be more ergonomic to kill two birds with one PR!

@ulysses4ever ulysses4ever requested a review from Kleidukos January 8, 2025 03:07
@ulysses4ever ulysses4ever changed the title try to figure out why static builds lack git info fix static builds lacking git info Jan 11, 2025
@ulysses4ever
Copy link
Collaborator

@Mikolaj @Kleidukos @ffaf1 can we get one more review here, please? I think everyone loves cabal-head. Let's make it even greater again with git info working for static builds!

@Kleidukos
Copy link
Member

@geekosaur I believe you can merge this PR!

@geekosaur geekosaur added the merge me Tell Mergify Bot to merge label Feb 27, 2025
@mergify mergify bot added merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days ready and waiting Mergify is waiting out the cooldown period labels Feb 27, 2025
Copy link
Contributor

mergify bot commented Feb 27, 2025

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@mergify mergify bot merged commit 409208f into haskell:master Feb 27, 2025
54 checks passed
@ulysses4ever
Copy link
Collaborator

I can confirm that the fresh static cabal-head has the Git info now! Thanks a ton @geekosaur!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge priority: high 🔥 ready and waiting Mergify is waiting out the cooldown period
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Git SHA isn't shown on cabal-head
3 participants