-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
package page adjustments #1355
base: master
Are you sure you want to change the base?
package page adjustments #1355
Conversation
Yes, please! In the "previously" you have screenshots for both desktop and mobile but for "now" it's only mobile. Is it possible to get desktop too? |
Yesterday GitHub didn’t wanna :P I can try again today |
sounds good. Keep us posted about that, please! |
@ulysses4ever today it worked :P |
@@ -283,9 +260,37 @@ | |||
<th>Status</th> | |||
<td>$buildStatus$</td> | |||
</tr> | |||
<tr> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok with moving to sidebar, but do not want it hidden by default. all the info except "edit package information" is generally relevant -- checking who the maintainers are, what the candidates are, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you still get the maintainer entry that is the cabal file - I feel like that the hackage maintainers and the candidates are technical details that don't matter for 99% of the people visiting a package page.
I can of course revert this change but I thought it would be nice to discuss this :)
e876c32
to
696eece
Compare
summary
Some cosmetic improvements
Feel free to accept only a subset of the commits, they're very much all proposals.
Sadly I cannot upload some of the pictures of the changes since github doesn't feel like it today
remove unnecessary visual noise:
previously
now
build in a tiny bit of semantic html
move maintainer's corner to the sidebar and hide it by default
make clear what Package Description refers to