Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package page adjustments #1355

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

MangoIV
Copy link
Contributor

@MangoIV MangoIV commented Jan 3, 2025

summary

Some cosmetic improvements

Feel free to accept only a subset of the commits, they're very much all proposals.

Sadly I cannot upload some of the pictures of the changes since github doesn't feel like it today

remove unnecessary visual noise:

  • remove the side bar
  • remove padding and margin on the left and right sides

previously

image
image

now

image
image

build in a tiny bit of semantic html

  • made the main part of the side somewhat navigatable

move maintainer's corner to the sidebar and hide it by default

  • it's the maintainer's corner it shouldn't steal the average visitor large parts of their field of view

make clear what Package Description refers to

  • there's an explainer already so no harm done in telling that this refers to the cabal file (I had to look this up myself :P)

@ulysses4ever
Copy link
Contributor

Yes, please!

In the "previously" you have screenshots for both desktop and mobile but for "now" it's only mobile. Is it possible to get desktop too?

@MangoIV
Copy link
Contributor Author

MangoIV commented Jan 4, 2025

Is it possible to get desktop too?

Yesterday GitHub didn’t wanna :P

I can try again today

@ulysses4ever
Copy link
Contributor

sounds good. Keep us posted about that, please!

@MangoIV
Copy link
Contributor Author

MangoIV commented Jan 5, 2025

@ulysses4ever today it worked :P

@MangoIV MangoIV changed the title Mangoiv/more space package page adjustments Jan 5, 2025
@@ -283,9 +260,37 @@
<th>Status</th>
<td>$buildStatus$</td>
</tr>
<tr>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with moving to sidebar, but do not want it hidden by default. all the info except "edit package information" is generally relevant -- checking who the maintainers are, what the candidates are, etc.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you still get the maintainer entry that is the cabal file - I feel like that the hackage maintainers and the candidates are technical details that don't matter for 99% of the people visiting a package page.

I can of course revert this change but I thought it would be nice to discuss this :)

@MangoIV MangoIV force-pushed the mangoiv/more-space branch from e876c32 to 696eece Compare January 29, 2025 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants