Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove getCompletionPrefix #552

Merged
merged 2 commits into from
Feb 5, 2024
Merged

Remove getCompletionPrefix #552

merged 2 commits into from
Feb 5, 2024

Conversation

michaelpj
Copy link
Collaborator

This has been in ghcide for a while, it's pointless having it here.

@michaelpj michaelpj merged commit 2bba471 into master Feb 5, 2024
14 checks passed
soulomoon pushed a commit to soulomoon/lsp that referenced this pull request Apr 8, 2024
* Remove getCompletionPrefix

* Format
@neduard
Copy link

neduard commented Jun 15, 2024

Hello! For the benefit of anyone searching, PosPrefixInfo was also removed as part of this commit

(mentioning this as both functions were part of the public API until 2.3.0.0 and people might be surprised when their packages stop compiling)

@fwcd
Copy link
Contributor

fwcd commented Jul 29, 2024

Makes sense as to why these were removed, but I admit that they were very convenient to have for Curry (which uses almost exactly the same syntax as Haskell), so I'm probably going to vendor them.

fwcd added a commit to fwcd/curry-language-server that referenced this pull request Jul 29, 2024
fwcd added a commit to fwcd/curry-language-server that referenced this pull request Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants