Anomaly detector detection re running in inspect mode #757 #759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rozetko
approved these changes
Aug 20, 2019
jonyrock
reviewed
Aug 20, 2019
| @@ -644,7 +644,7 @@ export async function getHSR( | |||
| hsr: TableTimeSeries, | |||
There was a problem hiding this comment.
let's make a class for this
There was a problem hiding this comment.
according TODOs we should make it in data-kit
related issue CorpGlory/grafana-datasource-kit#89
jonyrock
reviewed
Aug 20, 2019
jonyrock
reviewed
Aug 20, 2019
jonyrock
requested changes
Aug 20, 2019
Co-Authored-By: Alexey Velikiy <[email protected]>
' of github.com:hastic/hastic-server into anomaly-detector-detection-re-running-in-inspect-mode-#757
rozetko
reviewed
Aug 21, 2019
rozetko
reviewed
Aug 21, 2019
rozetko
reviewed
Aug 21, 2019
jonyrock
reviewed
Aug 21, 2019
jonyrock
requested changes
Aug 21, 2019
Co-Authored-By: Alexey Velikiy <[email protected]>
jonyrock
reviewed
Aug 21, 2019
jonyrock
reviewed
Aug 21, 2019
jonyrock
reviewed
Aug 21, 2019
' of github.com:hastic/hastic-server into anomaly-detector-detection-re-running-in-inspect-mode-#757
Co-Authored-By: rozetko <[email protected]>
' of github.com:hastic/hastic-server into anomaly-detector-detection-re-running-in-inspect-mode-#757
Co-Authored-By: Alexey Velikiy <[email protected]>
Co-Authored-By: Alexey Velikiy <[email protected]>
' of github.com:hastic/hastic-server into anomaly-detector-detection-re-running-in-inspect-mode-#757
rozetko
reviewed
Aug 21, 2019
rozetko
approved these changes
Aug 21, 2019
jonyrock
approved these changes
Aug 21, 2019
rozetko
deleted the
anomaly-detector-detection-re-running-in-inspect-mode-#757
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #757
Problem
getHSRmethod runs learning if cache of analytic unit isnullor outdated. Panel requests HSR every second and creates a race condition between learning process and HSR requests.Note: cache can't be outdated because learning started on each unit's update if it required in class definition.
Changes
LEARNINGstateisCacheOutdated