fix: cookies of request for aws lambda payload format v2

[princescar]

Put cookies back to headers to construct a complete request for hattip handler.

[cyco130]

Hi!

I don't understand the necessity of this. event.cookie seems to be purely for convenience, event.headers already seems to contain the cookie header as you can check below. It's a streaming AWS deployment of this test file. I also tested non-streaming version, works the same):

• https://fkqmja452u4kgyxwq32kymaega0gonjg.lambda-url.eu-west-3.on.aws/set-cookie (sets two cookies)
• https://fkqmja452u4kgyxwq32kymaega0gonjg.lambda-url.eu-west-3.on.aws/headers (dumps the request headers, should show the cookie header)
• https://fkqmja452u4kgyxwq32kymaega0gonjg.lambda-url.eu-west-3.on.aws/cookie (dumps parsed cookies)

Maybe there's a configuration setting that I'm not aware that requires your patch?

[princescar]

Hi @cyco130, I should mention that this is for the v2 payload format.

For the v2 payload, API gateway removes the Cookies header from event, and the hattip handler cannot get construct the full request with cookies.

References:

• https://docs.aws.amazon.com/apigateway/latest/developerguide/http-api-develop-integrations-lambda.html
• https://github.com/awslabs/aws-lambda-go-api-proxy/pull/109/files

[cyco130]

Hattip's also using v2. But if it's the API gateway that removes it, I wouldn't know because I don't use it (I just create a function URL and put it behind a CF worker, I'm cheap 😃).

How about only overwriting event.headers.cookie if it's empty (e.g. guard it with if (!event.headers.cookie) or something)? I'll merge if you can make a change to that effect.

Thanks for reporting!

[princescar]

Hey @cyco130, it's updated!