DOC-353 Prometheus metrics standardization #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for frosty-curran-1fc0c4 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
zhmaeff
reviewed
Jan 30, 2025
zhmaeff
reviewed
Jan 30, 2025
zhmaeff
reviewed
Jan 30, 2025
…ter so that the customer can use any Prometheus compatible monnitoring tool.
pollett
reviewed
Feb 4, 2025
oliverhowell
approved these changes
Feb 6, 2025
|
|
||
| The updated metrics are based on link:https://prometheus.io/docs/practices/naming/[Prometheus conventions]. | ||
|
|
||
| The following examples illustrate the differences between the original and updated metrics. |
There was a problem hiding this comment.
I wonder if an explicit hint is needed e.g.
Suggested change
| The following examples illustrate the differences between the original and updated metrics. | |
| The following examples illustrate the differences between the original and updated metrics (in each example, the original metric is shown first and then the updated metric). |
I might be overthinking it but thinking about Kapa consuming this content and also the 'rename and remove...' tense does read a little like a direction rather than something that has changed, if that makes sense.
|
|
||
| By default, Management Center exposes both the original metrics and the updated versions. Existing integrations will therefore continue to work, but you should consider the original metrics deprecated and plan to migrate to the updated versions. You can optionally xref:config[change which set of metrics is exposed]. | ||
|
|
||
| Management Center makes the following changes to metrics exposed by Hazelcast clusters. |
There was a problem hiding this comment.
Would a heading help?
Suggested change
| Management Center makes the following changes to metrics exposed by Hazelcast clusters. | |
| == Changes to metrics | |
| Management Center makes the following changes to metrics exposed by Hazelcast clusters. |
|
|
||
| == Disabling Timestamp | ||
| == Disabling Timestamps |
There was a problem hiding this comment.
I was reticent to suggest changing the headings away from gerunds but if you're fixing grammar you might want to consider it here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hazelcast.atlassian.net/browse/MC-3171
Related platform docs changes: hazelcast/hz-docs#1508