-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Syntax factory #1530
Merged
Merged
Syntax factory #1530
Changes from 13 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
7815d90
Add DefaultAnnotation module and factory functions for term annotations
7h3kk1d 168ee58
Added optional annotation params to factory methods and rewrite some …
7h3kk1d 96b7190
Nest functions under modules
7h3kk1d b797431
Migrate more tests
7h3kk1d fbf7226
More tests
7h3kk1d fc2299f
All references to the old error/no_error functions removed
7h3kk1d e1e1597
Use Grammar types for menhir
7h3kk1d 9496947
Merge branch 'syntax_playground' into syntax_factory
7h3kk1d 47c8e45
Merge branch 'syntax_playground' into syntax_factory
7h3kk1d b7c215a
Merge branch 'syntax_playground' into syntax_factory
7h3kk1d c5ebe7d
Stop using global mutable array in menhir conversion
7h3kk1d fd15107
Merge branch 'dev' into syntax_factory
7h3kk1d 3a85821
Remove unused UnitAnnotation module
7h3kk1d b5c2ecc
Move id indicated conversion to Conversion.re
7h3kk1d 59d90f5
Add FreshGrammar module to provide default IdTag values
7h3kk1d 3ce71cb
Use FreshGrammar in Test_Menhir
7h3kk1d d77e2f8
Use FreshGrammar in Test_MakeTerm
7h3kk1d 3affe2c
Remove unnecessary curly braces
7h3kk1d d679c16
Refactor built-in functions to use FreshGrammar
7h3kk1d e035475
Use FreshGrammar in Transition
7h3kk1d d2cf90f
Remove unused cls from Exp
7h3kk1d a564842
Add enumerate deriving to deriving for various types
7h3kk1d b6b6629
Add UnitGrammar module to Factory for unit type
7h3kk1d 933346d
Add sample_expression function to construct expressions from expressi…
7h3kk1d b760a03
Add tests for typ and pattern clsses
7h3kk1d 9d3f368
Added tpat classes test
7h3kk1d File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could have 2 types here
t
for the type of the annotation and another types
that could be used in the factory methods below and require adefault_value : option(s) -> t
as part of the builder. I haven't bothered but for optional annotations it allows the people calling the builder to use a different type like not provideSome
constructors.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
leave as a comment in the file