Fix issue135 #143
Closed
Fix issue135 #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
January 2, 2019 13:38
…ork with branches during local tests
Force DecompilerTestBase to visit decompiled expressions
|
The duplication ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi @hazzik
I had a look on this one.
I think the issue comes from overlooking the Processor's
OpCodes.Brtrue/Brtrue_Swhere the instruction is aLambdaExpressionreturning a bool.Here is just a PR to show the solution I found for issue #135, but I'm not sure it is exhaustive or not.
Anyway it does not seem to introduce tests regression so far.
The first test's failure is expected due to difference between both expressions' debugView