Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local device info object for pair/unpair #757

Merged
merged 1 commit into from
Feb 5, 2022

Conversation

harshdeepsehgal
Copy link
Contributor

@harshdeepsehgal harshdeepsehgal commented Feb 4, 2022

Added a local DeviceInformation object to make sure flags are updated to enable pairing and unpairing.

Solves #699

Copy link
Collaborator

@dlech dlech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Can you run black on the code to fix the formatting and add a changelog entry?

@harshdeepsehgal
Copy link
Contributor Author

harshdeepsehgal commented Feb 4, 2022

I have added the changelog entry. I did run black, it has reformatted files, but somehow it still fails the check.

@dlech
Copy link
Collaborator

dlech commented Feb 4, 2022

Black just came out with a new stable version. The CI is using black-22.1.0. Maybe you are using an older version? Or maybe we haven't run the new version on the code yet?

@harshdeepsehgal
Copy link
Contributor Author

Yes I was running an older version of black. It passed the checks now.

@dlech dlech merged commit f67eb44 into hbldh:develop Feb 5, 2022
@dlech
Copy link
Collaborator

dlech commented Feb 5, 2022

Thanks!

@harshdeepsehgal
Copy link
Contributor Author

Happy to contribute :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants