Support auto-complete suggestions created from multiple fields #2080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Like in lobid-gnd: configure fields to use in the `format` param (e.g. `json:title,contribution`), or use `format=json:suggest` for default fields. See https://jira.hbz-nrw.de/browse/RPB-141
|
This looks already very good. There is one place where we should probably improve it: When resources have multiple contributing agents, the list of names should be cut after the first person and an "et al." added (like in the lobid HTML result lists). |
|
Looking up the example in RPB Strapi, it looks like this (I don't know why there are four records for this resource):
|
|
Hm, but isn't that example a case where we actually need all authors to select the correct entry? |
|
Maybe we should just wait what RPB editors say. |
dr0i
approved these changes
Oct 10, 2024
|
Deployed to production, closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like in lobid-gnd: configure fields to use in the
formatparam (e.g.json:title,contribution), or useformat=json:suggestfor default fields.See https://jira.hbz-nrw.de/browse/RPB-141
Deployed to test: https://test.lobid.org/resources/api#auto-complete