Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: do not force python3.7 #326

Merged
merged 1 commit into from
May 19, 2023
Merged

ci: do not force python3.7 #326

merged 1 commit into from
May 19, 2023

Conversation

proppy
Copy link
Contributor

@proppy proppy commented Apr 27, 2023

This is a lame attempt at fixing #324.

/cc @xobs @PiotrZierhoffer @ajelinski

@mithro
Copy link
Member

mithro commented Apr 27, 2023

@proppy - We should probably be building against all Conda supported Python versions - https://conda.io/projects/conda/en/latest/user-guide/tasks/manage-python.html

Conda supports Python 3.8, 3.9, 3.10, and 3.11.

@proppy
Copy link
Contributor Author

proppy commented Apr 28, 2023

@proppy - We should probably be building against all Conda supported Python versions -

I think that's orthogonal to the version of python installed on the host; a given package should be able to specify the version of conda to build against in the workflow, see: https://github.com/hdl/conda-eda/blob/master/.github/workflows/Build.yml#L117

@proppy
Copy link
Contributor Author

proppy commented Apr 28, 2023

building against all Conda supported Python versions

Updated #190 to be more generic to track this.

@mithro
Copy link
Member

mithro commented Apr 30, 2023

Nothing should depend on the host's Python, it should be using the Python from conda?

@proppy
Copy link
Contributor Author

proppy commented May 1, 2023

Nothing should depend on the host's Python, it should be using the Python from conda?

Yes, that's my understanding as well that the conda's python is used after entering the recipe build procress, but I assume it is also installed on the host as some of the bootstrap scripts might require it?

@xobs
Copy link
Contributor

xobs commented May 1, 2023

I don't think it uses Python from the system, even when doing setup.

A similar-but-orthogonal issue is that a particular Python might not be available on the system. For example, python3.7 is unavailable on arm64, which is why openroad doesn't build on that platform.

@umarcor umarcor merged commit 6d8dac1 into hdl:master May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants