Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Oliver Ruebel <[email protected]>
  • Loading branch information
h-mayorquin and oruebel authored Nov 23, 2024
1 parent a5e0003 commit 4c267ba
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/hdmf/container.py
Original file line number Diff line number Diff line change
Expand Up @@ -741,7 +741,8 @@ def _generate_array_html(self, array, level):
"""Generates HTML for array data (e.g., NumPy arrays, HDF5 datasets, Zarr datasets and DataIO objects)."""

is_numpy_array = isinstance(array, np.ndarray)
it_was_read_with_io = self.get_read_io() is not None
read_io = self.get_read_io()
it_was_read_with_io = read_io is not None
is_data_io = isinstance(array, DataIO)

if is_numpy_array:
Expand All @@ -755,7 +756,6 @@ def _generate_array_html(self, array, level):
# 1. Array-type attributes (e.g., start_frame in ImageSeries) remain NumPy arrays
# even when their parent container has an IO
# 2. Data may have been modified after being read from storage
read_io = self.get_read_io()
repr_html = read_io.generate_dataset_html(array)
else: # Not sure which object could get here
object_class = array.__class__.__name__
Expand Down

0 comments on commit 4c267ba

Please sign in to comment.