Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve issue and PR templates #1004

Merged
merged 9 commits into from
Nov 27, 2023
Merged

Improve issue and PR templates #1004

merged 9 commits into from
Nov 27, 2023

Conversation

rly
Copy link
Contributor

@rly rly commented Nov 27, 2023

Motivation

Fix #1003. I also simplified the PR template to reduce the number of checkboxes and text.

I also reordered the Python versions in the issue template to newer first, and I changed the order of OS's to Mac first since that is currently used by all of the core HDMF developers.

How to test the behavior?

Need to merge this PR to see the changes.

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running ruff from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@rly rly requested a review from oruebel November 27, 2023 05:36
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.65%. Comparing base (1d7fd83) to head (0436e98).
Report is 92 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1004   +/-   ##
=======================================
  Coverage   88.65%   88.65%           
=======================================
  Files          45       45           
  Lines        9458     9458           
  Branches     2691     2691           
=======================================
  Hits         8385     8385           
  Misses        757      757           
  Partials      316      316           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rly rly merged commit e517883 into dev Nov 27, 2023
26 checks passed
@rly rly deleted the fix_issue_template branch November 27, 2023 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Change checkboxes in issue template
2 participants