-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Naive and frame pointer stack unwinders #61
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, sorry for a delay with the review - this is very cool, thanks! I left a few general comments and suggestions, and this can be merged after the merge conflict is resolved.
Later we can also integrate this with rustc-demangle
to have a quick win with getting real function names. I'll create a new issue for that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍 Merge seems to be blocked by a conflict though, could you please take a look at it?
Co-authored-by: Nikita Baksalyar <[email protected]>
ee57cca
to
0c71b2f
Compare
The naive unwinder scans the stack for words that could be function pointers, while the frame pointer unwinder uses the frame pointer linked list.
cc #60