Use separate camera thread #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Effectively fixing next bugs: * internaut#1 * internaut#2
| // update camera frame texture | ||
| GLES20.glActiveTexture(GLES20.GL_TEXTURE1); | ||
|
|
||
| camTexture.updateTexImage(); |
There was a problem hiding this comment.
As you can see there is no need to call windowSurface.makeCurrent(); before updateTexImage.
headupinclouds
added a commit
that referenced
this pull request
Oct 6, 2015
Use separate camera thread
| return; | ||
| } | ||
| if (dataReady) { | ||
| return; // TODO; Should be `if (!tryLock) { return; }` |
There was a problem hiding this comment.
I've tested ReentrantLock here but it seems that synchronized (lock) doesn't playing well with lock.tryLock().
I thought that we can do:
if(!lock.tryLock()) {
return; // exit immediately
}
lock.notify();
lock.unlock();But in fact it should be:
if(!lock.tryLock()) {
return;
}
synchronized (lock) {
lock.notify();
}
lock.unlock();which makes all the synchronization code looks quite ugly. I think we need to add new class or something (?)
headupinclouds
added a commit
that referenced
this pull request
May 14, 2017
hunterized unit tests; astyle formatting; new shaders; copyright/au…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for bugs:
Discover new bug (reproduced on old version too):