If a number is in an unexpected format, fallback to a standard (sanitized) number #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We base the formatting off the number of digits in a given phone number matched against the number of digit placeholders in any available phone format for a given region. An issue could arise when a yet-to-be-defined format is expected but not available, and forcing an overly-long phone number to be transposed into a number format, and leading digits could be omitted. With this change, an unexpected format will return as a plain-text, unformatted number that has gone through sanitization so it can safely be rendered. The one exception to this is region code 1, where adding the region code is uncommon, domestically. Tests added to cover this corner-case.